Ticket #51 (defect)
Opened 1 year ago
Last modified 1 year ago
In cookie.py, error with REMOTE_USER_TOKENS
Status: assigned
| Reported by: | anonymous | Assigned to: | guest (accepted) |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | component1 | Version: | |
| Keywords: | Cc: | ||
In authkit.authenticate.cookie, REMOTE_USER_TOKENS building is not correct, concatenating list with string. Attached patch fix the issue.
Attachments
Change History
05/15/08 13:33:31: Modified by jean.parpaillon@kerlabs.com
- attachment remote_user_tokens.diff added.
05/20/08 16:24:51: Modified by anonymous
- owner changed from somebody to guest.
- status changed from new to assigned.
Could you please attach a simple use case demonstrating how you are using this because I've had some trouble with this bit of functionality in the past and I want to make sure you aren't using it in a different way before applying the patch?
Perhaps using one of the form examples as a basis?
Cheers,
James
07/02/08 22:21:47: Modified by anonymous
When the patch will be applied to the trunk?
I have the same issue with forms that worked in 0.4.0.
09/10/08 00:03:08: Modified by anonymous
Hi. I'm running into this too using revision 156 of AuthKit? trunk. The bug is in the way tokens is handed off from parse_ticket() to CookieUserSetter(). It is simply missing one line of code to make the tokens a str not a list. If you look at paste's auth_tkt you will see the line of code is already there.
Here is a patch to fix it and an attempt at writing a test for it. alas, I could not find an easy way to generate a cookie value with the hex digest and secret, etc, that can be used for the test. Maybe you know an easy way? So the test fails with a forced ValueError? at the moment. My patch did not cause any other tests to fail but this part of the code is not tested anyway (I checked).
the patch is from svn diff and can be applied with patch -p0
09/10/08 00:04:02: Modified by anonymous
- attachment authkit-token-fix.patch added.
fixes tokens bug and attempts to create a test for the fix
09/10/08 00:05:22: Modified by anonymous
oh also, can you email me kumar.mcmillan @ gmail ? couldn't find a way to register a trac account. thx.
Fix for #51